fix(desktop): fix macOS orphaned process cleanup on startup #12238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation used `killall opencode-cli` which doesn't match the actual process name. The binary is named `opencode`, not `opencode-cli`. This caused orphaned processes to accumulate across app restarts, leading to: - Memory leak (observed 5 opencode processes consuming 1.3GB RAM) - WebView white screen when system memory pressure kills the render process Changes: - Use `pkill -f` to match processes by full path instead of process name - Clean up all three process types: opencode, openwrk, openwork-server - Add comments explaining the purpose of the cleanup
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: Related PR:
The searches consistently returned only PR #12238 (the current PR), which suggests there are no other open PRs directly addressing macOS orphaned process cleanup or the specific |
Collaborator
|
The CLI process is definitely called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12240
Summary
Fix orphaned process cleanup on macOS that was causing white screen issues due to memory accumulation.
Problem
The previous implementation used
killall opencode-cliwhich doesn't match the actual process name (opencode). This caused:Solution
pkill -fto match processes by full path instead of process nameopencode,openwrk,openwork-serverChanges
packages/desktop/src-tauri/src/lib.rs: Replacekillall opencode-cliwithpkill -fcommands for all OpenWork processes